feat(agent-tools): tighten tool approvals and shortcuts#1343
Merged
Conversation
- Require permissions for Write, Edit, and Delete tool execution - Add a FlowChat approval-bar shortcut to enable tool auto execute - Separate the auto-execute shortcut from per-run approval actions with neutral default styling - Add localized approval-bar copy for auto execute success, failure, label, and tooltip - Allow Claw mode to use WebFetch and simplify Cron tool descriptions - Cover the auto-execute shortcut with focused ToolApprovalBar tests
Clamp html5ever and selectors to WARN in desktop and CLI logging so WebFetch readable extraction no longer floods app logs with parser debug output. Move notify from OFF to WARN to keep file-watcher warnings and errors visible while still suppressing lower-level noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require approval for file-modifying tools and add a FlowChat approval-bar shortcut for enabling tool auto execute.
Fixes #
Type and Areas
Type:
Feature / UI/UX / test
Areas:
Rust core, web UI, FlowChat, settings/i18n
Motivation / Impact
Write, Edit, and Delete now report that they need permissions, so file modifications flow through the approval path even when wrapped by snapshot tracking.
The FlowChat approval bar now includes a secondary ShieldCheck action that enables tool auto execute by updating
ai.skip_tool_confirmation. The action is visually separated from the per-run allow/reject controls, uses neutral styling by default, and shows its emphasized state on hover.This also adds localized approval-bar copy, test coverage for the shortcut, WebFetch availability in Claw mode, and shorter Cron tool descriptions.
Verification
cargo check -p bitfun-corepnpm run type-check:webpnpm --dir src/web-ui run test:run src/flow_chat/components/ToolApprovalBar.test.tsxpnpm run i18n:auditReviewer Notes
The auto-execute shortcut only enables the global setting; it does not implicitly approve the currently pending tool call.
Checklist